Deprecate the exporters in the "trace" and "metric" sub-directories #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
release:1.0.0-rc.1
pkg:exporter:prometheus
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo and
XSAM
as code owners
MrAlias
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1993 +/- ##
========================================
- Coverage 72.1% 41.5% -30.7%
========================================
Files 159 216 +57
Lines 7923 15668 +7745
========================================
+ Hits 5719 6512 +793
- Misses 1975 8760 +6785
- Partials 229 396 +167
|
MrAlias
force-pushed
the
rm-export-signal-dirs
branch
from
8bf1c97 to
2de32a9
Compare
|
Markdown lint check is going to fail until this is merged into |
MrAlias
changed the title
Aneurysm9
approved these changes
Jun 11, 2021
dashpole
approved these changes
Jun 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
no new Go code is included in this change -- all exporter packages that are being deprecated have been copied to their new location.
go.opentelemetry.io/otel/exporters/metric/prometheusis deprecated in favor ofgo.opentelemetry.io/otel/exporters/prometheus.go.opentelemetry.io/otel/exporters/trace/jaegeris deprecated in favor ofgo.opentelemetry.io/otel/exporters/jaeger.go.opentelemetry.io/otel/exporters/trace/zipkinis deprecated in favor ofgo.opentelemetry.io/otel/exporters/zipkin./traceand/metricmodules./traceand/metricmodules.Background
All exporters used to be grouped in the
metricortracedirectory within theexporterdirectory. When we introduced metric support to thestdoutandotlpexporters, which already supported tracing, they did not fit in either directory and were moved up one level. Now that the OTLP exporter is being split internally into trace and metric packages it has forced the question if thetraceandmetricdirectory withinexportersmakes sense.It does not. It is an added hierarchical level to a package name that does not add useful context. Users of Prometheus know it is used for metrics and users of Jaeger and Zipkin know they are used for tracing.
This is a conclusion the rest of the OpenTelemetry SDKs have also realized. They have all included these exporters at the same directory level:
This change starts the removal of duplicate and unneeded hierarchical separation and unifies on a project structure closer matching the rest of the OpenTelemetry community. The deprecated package are planned to be removed for the
1.0.0release.